WAITP-1466: Account Settings – Personal Details #5169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7b612fb.
* tile component * Show modal when exiting survey via home button * Remove unused imports * Stop menu re-rendering on change of survey screen * Update button disabled state * Fix build errors * Fix tests * Close side menu on screen change on mobile * clean up code from another branch * Update LandingPage.tsx --------- Co-authored-by: Tom Caiger <caigertom@gmail.com>
* WAITP-1377 Forward signup route to web config server * WAITP-1377 Fixup lint
* WIP visibility criteria * Working survey visibility criteria * Generate types * Add tests * Redirect user if survey screen is not visible * Reset invisible answers * Handle when value is not an array * Remove only from test * Fix tests * Conditional questions working * Get question fully updating * Generate types * Add tests and update types * Update survey.json * Fix types and build * Fix tests * Initial logic and separate out context * Working arithmetic question * Fix tests and build * Generate types * Fix types * Add tests * WIP * WIP * WIP * WIP * Working qr code * Fix types * Update test * Fix tests * PR fixes
* WIP * Use built in functionality * Add comment * Fix build errors
* Update LandingPage.tsx * update landing page * data fetching layer * fix console errors * re organise landing page * tooltips * style tweaks * update landing page layout * horizontal scroll * page limit
* Update LandingPage.tsx * update landing page * data fetching layer * fix console errors * re organise landing page * tooltips * style tweaks * update landing page layout * horizontal scroll * page limit * project select page * menu ux * Update useSubmitSurvey.ts * gps question * Update index.html * Update ProjectsRoute.ts * theming * Update mui.d.ts * Update useSubmitSurvey.test.ts
* no-issue: Add @tupaia/server-utils package (#5121) * RN-1060: (task) Moved sendEmail to @tupaia/server-utils (#5126) * RN-1060: (task) Added dashboards/:project/:entity/:dashboard/export route to tupaia-web (#5125) * WAITP-1354: Leaderboard * Update copyright * Update internal email * Update email filter * Fix response type * Update packages/datatrak-web/src/features/Leaderboard/LeaderboardTable.tsx Co-authored-by: Tom Caiger <caigertom@gmail.com> * Update background variable * Update branch name validation script (#5136) * Update to use new leaderboard model * Revert "Merge branch 'dev' into waitp-1354-leaderboard" This reverts commit c2acdbe, reversing changes made to 747f182. * Fix types * Update packages/database/src/modelClasses/SurveyResponse.js Co-authored-by: Rohan Port <59544282+rohan-bes@users.noreply.github.com> * PR fixes * Fix error --------- Co-authored-by: Rohan Port <59544282+rohan-bes@users.noreply.github.com> Co-authored-by: Tom Caiger <caigertom@gmail.com> Co-authored-by: Ethan McQuarrie <69437175+EMcQ-BES@users.noreply.github.com>
* Update LandingPage.tsx * update landing page * data fetching layer * fix console errors * re organise landing page * tooltips * style tweaks * update landing page layout * horizontal scroll * page limit * Frontend layout * Working request * Refetch recent surveys on submit * Fix recent survey request and styling * Use grid and update heading element * Remove unnecessary css * PR fixes --------- Co-authored-by: Tom Caiger <caigertom@gmail.com>
* WIP * Account deletion * Update component for section * Update modals * Remove forced open state * Fix types * fix build error * Update packages/datatrak-web/src/api/mutations/useEditUser.ts Co-authored-by: Tom Caiger <caigertom@gmail.com> * Update packages/datatrak-web/src/api/mutations/useEditUser.ts Co-authored-by: Tom Caiger <caigertom@gmail.com> * Change format * fix bad merge * return zeros for rewards --------- Co-authored-by: Tom Caiger <caigertom@gmail.com>
* WIP * Use built in functionality * Add comment * Fix build errors * Working file upload * Fix build * Remove unused vars * Update format of file upload answers * Update schemas.ts * Update processSurveyResponse.test.ts * Update upsertAnswers.js --------- Co-authored-by: Tom Caiger <caigertom@gmail.com>
* fix rewards types * update primary entity question name
merge latest dev before testing
# Conflicts: # packages/datatrak-web/src/api/mutations/useEditUser.ts
jaskfla
commented
Feb 14, 2024
merge latest dev before testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue WAITP-1466: Account Settings – Personal Details
Changes
New feature. Implemented form in DataTrak → Account Settings → Personal Details for editing the account details of the currently logged in user.
The fields are repopulated with the current values. Email associated with the account is not changeable by design (see Figma document).
See also #5225 and #5243
Shout out to @tcaiger for his tremendous help on this one 🙏
Known issues
When the form is successfully submitted, the underlying form state is not updated to recognise that these new values are the canonical current values (until the page is reloaded).The Save changes button does not currently disable while the form is being submitted. Should prevent any subsequent form submissions until the last one is complete.Fixed.When “removing” the phone number (by submitting with an empty “Contact number” field), this is stored as an empty string in the database. Should probably be NULL.WAITP-1466: Account Settings – Personal Details 3 (Sanitise Data & Removabletel) #5243 fixes thisThe tooltip on the “Email” field doesn’t match the design in Figma.Strings are not trimmed; leading/trailing whitespace is stored into database.WAITP-1466: Account Settings – Personal Details 3 (Sanitise Data & Removabletel) #5243 fixes thisScreenshots
Large size class
Small and medium size classes