WAITP-1351 Datatrak link to tupaia and log in #5217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexd-bes
requested changes
Nov 27, 2023
| <SurveyAlertContent> | ||
| <ButtonWrapper> | ||
| <ButtonLink to={ROUTES.SURVEY_SELECT}>Select survey</ButtonLink> | ||
| <Button variant="outlined" onClick={async () => { |
There was a problem hiding this comment.
I think that because the logic here is more than just 1 line, we should move this out from being inline. I also think that we should make this a mutation that we call on click, and then onSuccess it can open Tupaia using the login token that is returned
packages/tupaia-web/src/Routes.tsx
Outdated
| @@ -52,6 +53,15 @@ const UserPageRedirect = ({ modal }: { modal: MODAL_ROUTES }) => { | |||
| * | |||
| * **/ | |||
| export const Routes = () => { | |||
| const [urlSearchParams] = useSearchParams(); | |||
| const { mutate: attemptLogin } = useOneTimeLogin(); | |||
| const token = urlSearchParams.get(URL_SEARCH_PARAMS.ONE_TIME_LOGIN_TOKEN); | |||
There was a problem hiding this comment.
I'd probably suggest moving this into it's own custom hook, and then calling the custom hook from here. Just because there are a few lines of logic but all related to this one thing, and it keeps it contained
alexd-bes
approved these changes
Nov 30, 2023
packages/datatrak-web/src/views/LandingPage/SurveySelectSection.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: WAITP-1351
Changes:
oneTimeLogintoken fromdatatrak-web-serverExplore Datalink to actually link you to tupaialoginTokento be applied