no-issue: Split DataBroker pullMetadata API per type #5288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kael89
commented
Dec 17, 2023
| ['delete', [{ code: 'DHIS_01', type: 'dataElement' }, { value: 2 }, TO_OPTIONS]], | ||
| ['pullMetadata', [{ code: 'DHIS_01', type: 'dataElement' }, TO_OPTIONS]], | ||
| ]; | ||
| it('passes mapping to service: push', async () => { |
There was a problem hiding this comment.
This section is just breaking apart the parameterised tests into separate test blocks per API
I think parameterised tests should only be used for simple, pure functions where we want to test multiple variations for the same API, e.g. maths, date handling etc. They are probably overused in tupaia (guilty as charged!)
|
Thanks for the review @edmofro, can I merge this? |
|
Yes go for it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting
DataBroker.pullMetadatainto two APIs, one for data elements and one for data group.Splitting the Service APIs will be done in another PR