WAITP-1517: Datatrak improvements #5292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue WAITP-1517: Datatrak performance and accessibility improvements
Changes:
Improved results in Accessibility and SEO, and some slight performance improvements (mainly to do with Cumulative Layout Shift):
Remaining issues for accessibility are colour contrast which would require some design input.
Remaining SEO issues are re: robots.txt and is likely because I was testing on a feature branch, not on production
Remaining performance issues are around the size of the files and may be improved with CDN updates to come