Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WAITP-1511: map overlay error handling #5306

Merged
merged 2 commits into from
Dec 22, 2023
Merged

WAITP-1511: map overlay error handling #5306

merged 2 commits into from
Dec 22, 2023

Conversation

alexd-bes
Copy link
Contributor

@alexd-bes alexd-bes commented Dec 21, 2023 •
edited
Loading

Issue WAITP-1511: map overlay error handling

Changes:

  • Show an error message and option to refetch when an error is caught for map overlay data\
  • Don't show blank map overlay data when an error is caught
  • Fix issue with map overlays reloading on open/close of the library

Screenshots:

Screenshot 2023-12-21 at 3 04 54 pm
Screenshot 2023-12-21 at 3 05 09 pm

tcaiger
tcaiger approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@tcaiger tcaiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@alexd-bes alexd-bes merged commit b7d5ad8 into dev Dec 22, 2023
42 checks passed
@alexd-bes alexd-bes deleted the waitp-1511-map-overlay-error-handling branch December 22, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcaiger tcaiger tcaiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexd-bes @tcaiger