WAITP-1524: Make survey project_id field non-nullable #5312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohan-bes
approved these changes
Jan 8, 2024
| @@ -37,6 +38,15 @@ const buildAndInsertDataGroup = async (models, fields) => { | |||
| ); | |||
| }; | |||
|
|
|||
| const buildAndInsertProject = async models => { | |||
| const uniqueId = generateId(); | |||
There was a problem hiding this comment.
Suggested change
| const uniqueId = generateId(); | |
| const uniqueId = generateTestId(); |
It's generally best to use the generateTestId function when working in tests. This is because we rely on a regex of ids containing the string test in order to work out what data to clean up.
Now that we've switched to using the tupaia test database, we really ought to just completely truncate all the data. But until we do that we need to use generateTestId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue WAITP-1524: Make survey project_id field non-nullable
Changes: