Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-issue: Fix persistent DataTrak sidebar #5314

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Conversation

jaskfla
Copy link
Contributor

@jaskfla jaskfla commented Jan 8, 2024

Changes

In medium and smaller size classes (where the hamburger menu appears as a drawer/sidebar) it would not dismiss when you clicked Account settings. This PR fixes that.


Screenshots

Screenshot 2024-01-09T091607

Copy link
Contributor

@alexd-bes alexd-bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing!

@jaskfla jaskfla enabled auto-merge (squash) January 8, 2024 22:20
@jaskfla jaskfla merged commit ed69521 into dev Jan 8, 2024
42 checks passed
@jaskfla jaskfla deleted the fix-persistent-sidebar branch January 8, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants