tweak: odds & sods #5478
Merged
tweak: odds & sods #5478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/admin-panel/src/VizBuilderApp/context/VizConfig.jsx
# Conflicts: # packages/admin-panel/src/VizBuilderApp/context/VizConfig.jsx
# Conflicts: # packages/admin-panel/src/VizBuilderApp/components/PreviewOptions.jsx
jaskfla
commented
Apr 4, 2024
There was a problem hiding this comment.
For some reason this file was set as executable. Just changed it back into a regular plaintext file
# Before
$ ls -al | grep gitignore
-rwxr-xr-x@ 1 Jasper staff 25 2 Nov 10:31 .gitignore
# After
ls -al | grep gitignore
-rw-r--r--@ 1 Jasper staff 25 2 Nov 10:31 .gitignoreNot sure why GitHub shows this as an empty file in the diff. You can verify that it’s not empty by viewing the file
jaskfla
commented
Apr 4, 2024
There was a problem hiding this comment.
Just a short-circuit, otherwise lines 73–88 get executed for no reason
rohan-bes
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
What's the purpose of deleting this?
There was a problem hiding this comment.
Ah, probably unclear in the diff UI, but that’s the only file in /meditrak-server. This PR deletes the unused package
There was a problem hiding this comment.
Oh I see! Thanks for cleaning up 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge checklist
Changes
meditrak-serverpackagepackage.jsons to https://bes.auVizConfigCustomLandingPagesPageTablePaginator