deps: RN-1112: bump knex to 3.1.0
#5483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohan-bes
requested changes
Mar 15, 2024
There was a problem hiding this comment.
Would it be alright for me to ask you to look into exactly what's going wrong with the failing test in the @tupaia/database package when we upgrade it?
It looks like once again it's related to jsonb operators (we use them in the dashboard_relation.entity_attributes_filter functionality). If it's possible for us to find out how to get that working on the latest version of knex I'd love if we could upgrade globally 👍
rohan-bes
requested changes
Apr 2, 2024
Co-authored-by: Rohan Port <59544282+rohan-bes@users.noreply.github.com>
jaskfla
commented
Apr 2, 2024
rohan-bes
reviewed
Apr 2, 2024
rohan-bes
approved these changes
Apr 4, 2024
# Conflicts: # packages/data-lake-api/package.json # packages/database/package.json # packages/types/package.json # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue RN-1112: Bump
knexto 3.1.0Changes
@tupaia/database’sgetColSelector()currently produces->and->>JSON selectors in its output, but for some reason this breaks with newer versions of Knex where positional parameters get out of order and messes up queries. I’ve fixed this by makinggetColSelector()construct equivalent queries using#>>, but usage of the function remains the same. It should continue to be provided input strings with->and->>.