Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-issue: Bump node version to 20.11.1 #5485

Merged
merged 2 commits into from
Mar 14, 2024
Merged

no-issue: Bump node version to 20.11.1 #5485

merged 2 commits into from
Mar 14, 2024

Conversation

rohan-bes
Copy link
Collaborator

As part of RN-952 we want to start using the bitwarden cli, which requires Node 18+

Given that Node 16 went out of maintenance at the start of the year, seems like a good time to upgrade.

Copy link
Contributor

@jaskfla jaskfla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@jaskfla
Copy link
Contributor

jaskfla commented Mar 8, 2024

I think a GitHub is migrating all of their actions away from 16 in favour of 21 too, which will require updating the @ versions on a couple things in our GitHub Action workflows

Figured that’s out-of-scope for this ticket, though (and perhaps under devops’ jurisdiction)?

@rohan-bes rohan-bes merged commit 531be92 into dev Mar 14, 2024
42 checks passed
@rohan-bes rohan-bes deleted the bump-node-18 branch March 14, 2024 05:37
@jaskfla jaskfla mentioned this pull request Mar 17, 2024
3 tasks
@jaskfla jaskfla changed the title no-issue: Bump node version to 18.19.1 no-issue: Bump node version to 20.11.1 Mar 17, 2024
@rohan-bes rohan-bes mentioned this pull request Mar 24, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants