deps: RN-1112: bump axios to ≥0.28
#5493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexd-bes
reviewed
Mar 18, 2024
# Conflicts: # packages/admin-panel/package.json # yarn.lock
jaskfla
changed the title
axios to ≥0.28axios to ≥0.28
This was referenced Apr 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue RN-1112: Bump
axiosto ≥0.28Changes
This PR supersedes the #5489 Dependabot PR of high severity, though does not resolve all current Dependabot alerts related toaxiosvulnerabilities in all packages. In particular, the Cross-Site Request Forgery Vulnerability patch requires ≥1.6.0, but this breaks a few PSSS tests. Hence upgrading PSSS just to 0.28, which resolves 3 of the 4 Dependabot alerts.For PSSS: Changelog shows a handful of backports from 1.x versions ofaxios, but seems to be additions not breaking changes.For others: Couple deprecations from the 1.0.0 release, but tests passing with 1.6.7.This PR supersedes the #5489 Dependabot PR, which resolves four alerts including one of high severity.
There are a couple deprecations from the 1.0.0 release, but tests are passing with 1.6.8. Unrelated to the deprecations, the 1.0.0 also switched from using CommonJS to ECMAScript, which has caused an issue with Jest. For us, this affects only PSSS. I’ve used a workaround that seems to appear all over StackOverflow and Axios’s GitHub discussions.