Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(centralServer): remove legacy requestCountryAccess endpoint #5509

Merged
merged 6 commits into from
Apr 4, 2024

Conversation

jaskfla
Copy link
Contributor

@jaskfla jaskfla commented Mar 15, 2024

Changes

Removes legacy /user/:userId/requestCountryAccess endpoint from central-server, which was deprecated in favour of /me/requestCountryAccess with MediTrak 1.7.93 (March 2019). Based on this September 2023 internal Slack thread, it seems the oldest actively used version in 2023 was 1.7.106.

@jaskfla jaskfla changed the title no-issue: Remove legacy requestCountryAccess endpoint no-issue: Remove legacy requestCountryAccess endpoints Mar 27, 2024
@jaskfla jaskfla changed the title no-issue: Remove legacy requestCountryAccess endpoints no-issue: Remove legacy requestCountryAccess endpoint Mar 27, 2024
@jaskfla jaskfla changed the title no-issue: Remove legacy requestCountryAccess endpoint tweak!: remove legacy requestCountryAccess endpoint Apr 4, 2024
@jaskfla jaskfla changed the title tweak!: remove legacy requestCountryAccess endpoint tweak: remove legacy requestCountryAccess endpoint Apr 4, 2024
@jaskfla jaskfla marked this pull request as ready for review April 4, 2024 00:49
@jaskfla jaskfla changed the title tweak: remove legacy requestCountryAccess endpoint tweak(central): remove legacy requestCountryAccess endpoint Apr 4, 2024
@jaskfla jaskfla changed the title tweak(central): remove legacy requestCountryAccess endpoint tweak(centralServer): remove legacy requestCountryAccess endpoint Apr 4, 2024
Copy link
Collaborator

@rohan-bes rohan-bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@jaskfla jaskfla merged commit b2c0d4b into dev Apr 4, 2024
45 checks passed
@jaskfla jaskfla deleted the remove-old-requestcountryaccess branch April 4, 2024 01:23
@jaskfla jaskfla mentioned this pull request Apr 4, 2024
1 task
@avaek avaek mentioned this pull request Apr 8, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants