Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak(environment): RN-1225: Override with local env if exists #5564

Merged
merged 1 commit into from
Apr 4, 2024
Merged

tweak(environment): RN-1225: Override with local env if exists #5564

merged 1 commit into from
Apr 4, 2024

Conversation

alexd-bes
Copy link
Contributor

Issue RN-1225: Override env vars with package file only if exists

Changes:

  • Turns out the first var is used if there is double up. We want it to use the last var, and only use the package env file if it exists.

jaskfla
jaskfla approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@jaskfla jaskfla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spotting—thanks for putting this through 🎉

@alexd-bes alexd-bes merged commit 56032fe into dev Apr 4, 2024
43 checks passed
@alexd-bes alexd-bes deleted the rn-1225-override-if-exists branch April 4, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaskfla jaskfla jaskfla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexd-bes @jaskfla