fix: /report endpoint date validation
#5575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaskfla
commented
Apr 9, 2024
| @@ -6,7 +6,7 @@ | |||
| import moment from 'moment'; | |||
| import momentTimezone from 'moment-timezone'; | |||
|
|
|||
| export const ISO_DATE_PATTERN = /^\d{4}-\d{2}-\d{2}$/; | |||
| export const ISO_DATE_PATTERN = /\d{4}-\d{2}-\d{2}/; | |||
There was a problem hiding this comment.
This also works:
Suggested change
| export const ISO_DATE_PATTERN = /\d{4}-\d{2}-\d{2}/; | |
| export const ISO_DATE_PATTERN = /^\d{4}-\d{2}-\d{2}/; |
Feel free to commit the suggestion directly if you prefer it
alexd-bes
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://beyondessential.slack.com/archives/C01MAA3NKM1/p1712622483211609
Changes
Just removed
^and$from the regex pattern I was using to validate date parameters. Specifically, it’s the$that breaks it, but I cannot for the life of me see why 😕Strictly speaking, this now allows anything that has a substring in the
YYYY-MM-DDformat to pass validation, but these inputs aren’t ever hand-written anyway (as far as I know). Ultimately it would result in another error saying that the date is null (since the server would then fail to parse it)—just a slightly less helpful error message.