Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change name of the API #210

Merged
merged 6 commits into from
Jul 5, 2022
Merged

Conversation

wtrocki
Copy link
Contributor

@wtrocki wtrocki commented Jul 1, 2022

Content, UX and API team trying to unify api names. All instance apis should have common names to help users to understand architecture.
Small change. Mostly harmless - it will only affect SDK comments.

@wtrocki
Copy link
Contributor Author

wtrocki commented Jul 1, 2022

CC @MikeEdgar

@wtrocki
Copy link
Contributor Author

wtrocki commented Jul 4, 2022

CC @biswassri

Copy link
Contributor

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wtrocki I don't think this change is enough for what you want to do. The OpenAPI file should be regenerated and checked in typically.

@wtrocki
Copy link
Contributor Author

wtrocki commented Jul 4, 2022

OpenAPi file is regenerated - I wanted to avoid conflicts. Noticed that we were missing docs for generation so added that to Readme.md

@wtrocki
Copy link
Contributor Author

wtrocki commented Jul 4, 2022

Found it. Ignore me for now

@wtrocki
Copy link
Contributor Author

wtrocki commented Jul 4, 2022

Should to do the work

@wtrocki
Copy link
Contributor Author

wtrocki commented Jul 5, 2022

🙏 🙈

@MikeEdgar MikeEdgar merged commit fd16d8a into bf2fc6cc711aee1a0c2a:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants