Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MGDSTRM-9401] Disable idempotence and retries for producer endpoint #221

Merged
merged 2 commits into from
Aug 9, 2022
Merged

[MGDSTRM-9401] Disable idempotence and retries for producer endpoint #221

merged 2 commits into from
Aug 9, 2022

Conversation

MikeEdgar
Copy link
Contributor

Bump Kafka test broker images and client to use version 3.2

@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@MikeEdgar MikeEdgar added this to the 0.12.0 milestone Aug 8, 2022
rareddy
rareddy approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

reading the docs, if you do not explicitly set it, but reducing the ACKs to not all also has a similar effect. But I like the explicit setting better.

@biswassri
Copy link
Contributor

@MikeEdgar Just wanted to confirm, that you're also upgrading the dependencies for Kafka 3.2.1, right? [MGDSTRM-9328]

@MikeEdgar
Copy link
Contributor Author

upgrading the dependencies for Kafka 3.2.1

Yes, I hadn't noticed that issue.

@biswassri
Copy link
Contributor

Yes, I hadn't noticed that issue.

No worries! I just wanted confirm it.

biswassri
biswassri approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@biswassri biswassri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@MikeEdgar MikeEdgar merged commit c187078 into bf2fc6cc711aee1a0c2a:main Aug 9, 2022
@MikeEdgar MikeEdgar deleted the kafka-3.2.1 branch August 9, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biswassri biswassri biswassri approved these changes

@rareddy rareddy rareddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MikeEdgar @biswassri @rareddy