Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend for csv based datasets #600

Merged
merged 4 commits into from
Jul 28, 2024
Merged

backend for csv based datasets #600

merged 4 commits into from
Jul 28, 2024

Conversation

bghira
Copy link
Owner

@bghira bghira commented Jul 26, 2024

No description provided.

@bghira bghira force-pushed the feature/csv-backend-arcade-ai branch from 45bffcf to a87a783 Compare July 27, 2024 13:44
@bghira
Copy link
Owner Author

bghira commented Jul 27, 2024

@williamzhuk did you ever manage to get this working? it looks like it has some big issues. i have managed to sort those out, i believe.

@bghira
Copy link
Owner Author

bghira commented Jul 27, 2024

a big issue encountered exists on multi-gpu systems. when you're calling save_state() on the csv backend, it will do this across multiple processes. each process will have its own different copy of the CSV. it seems like this functionality cannot work for this backend on multi-gpu systems.

@bghira bghira merged commit 72f4dfb into main Jul 28, 2024
1 check passed
@bghira bghira deleted the feature/csv-backend-arcade-ai branch July 28, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant