config file versioning to allow updating defaults without breaking backwards compat #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 29, 2024 09:49
…isting configs and 2 for new configs
bghira
commented
Jul 29, 2024
Comment on lines
-1023
to
-1026
| def split_cache_between_processes(self, prompts: list): | ||
| # Use the accelerator to split the data | ||
| with self.accelerator.split_between_processes(prompts) as split_files: | ||
| self.prompts = split_files |
bghira
commented
Jul 29, 2024
| @@ -416,23 +415,6 @@ def _reduce_bucket( | |||
| # ) | |||
| return relevant_files | |||
|
|
|||
| def split_cache_between_processes(self): | |||
| self.local_unprocessed_files = self.discover_unprocessed_files(self.cache_dir) | |||
There was a problem hiding this comment.
now being assigned in discover_new_files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.