Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when using jsonl files #611

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Fix crash when using jsonl files #611

merged 1 commit into from
Aug 2, 2024

Conversation

swkang-rp
Copy link
Contributor

Thanks for supporting jsonl, btw jsonl file crashes here.

Followed similar pattern in parquet.py.

@bghira bghira merged commit bdd222e into bghira:main Aug 2, 2024
@bghira
Copy link
Owner

bghira commented Aug 2, 2024

thanks. we might actually want to use orjsonl eventually because it's so much faster, and supports compressed volumes.

@swkang-rp swkang-rp deleted the bugfix/jsonl branch August 2, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swkang-rp @bghira