-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI for Threshold #1
base: master
Are you sure you want to change the base?
Conversation
@stevenDowns thank you! The diff is quite extensive so I will need some time to review the changes. |
CometAnalyzer.java
Outdated
|
||
|
||
private int getXIntensityCentroid(ImageProcessor ip){ | ||
// double sumpix = 0.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a number of places, commented out code is left but indentation (and sometimes new lines) are removed. Can these be reverted to keep the original?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so you want to keep the commented out code? Is there a reason? there may be a better way to store it is why I ask.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be fine to remove commented out code but keeping it in a mangled form doesn't make sense. My suggestion is just to revert these changes and keep the original, that's the easiest option I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. I tried to go back through this file and add back the commented out code with their decompressed formats. If you spot a place I missed, put a comment at the line. I only went through this file, CometAnalyzer. If other files had this issue. I will look through them and try to restore the commented out code lines as they were.
Readd comments and their decompressed formats.
Project Changes
Code Style Changes
a==b
becomesa == b
a,b
becomesa, b
Refactors
New Functionality