Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI for Threshold #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

stevenDowns
Copy link

Project Changes

  • Created a .gitignore file to prevent .class and .jar files from being checked in

Code Style Changes

  • White space changes:
    • Adding a space between operators a==b becomes a == b
    • Adding a space after commas a,b becomes a, b
  • large if blocks over the same value get rewritten as switch

Refactors

  • Organized static values and user inputs used by Analyzer in the new object named CometConfiguration

New Functionality

  • Added new object: CometConfiguration.
  • Allow users to change the minimum threshold(numeric)
    • The threshold before was hardcoded to the Huang minimum threshold value.

image

@bgyori
Copy link
Owner

bgyori commented Mar 16, 2020

@stevenDowns thank you! The diff is quite extensive so I will need some time to review the changes.



private int getXIntensityCentroid(ImageProcessor ip){
// double sumpix = 0.0;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a number of places, commented out code is left but indentation (and sometimes new lines) are removed. Can these be reverted to keep the original?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so you want to keep the commented out code? Is there a reason? there may be a better way to store it is why I ask.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be fine to remove commented out code but keeping it in a mangled form doesn't make sense. My suggestion is just to revert these changes and keep the original, that's the easiest option I think.

Copy link
Author

@stevenDowns stevenDowns Aug 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I tried to go back through this file and add back the commented out code with their decompressed formats. If you spot a place I missed, put a comment at the line. I only went through this file, CometAnalyzer. If other files had this issue. I will look through them and try to restore the commented out code lines as they were.

Readd comments and their decompressed formats.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants