[Discover] Minor cleanup (elastic#90260) (elastic#90283)

bhavyarm · Feb 4, 2021 · af940d5 · af940d5
1 parent f9b2ad1
commit af940d5
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 454 deletions.
diff --git a/src/plugins/discover/public/application/embeddable/search_embeddable.ts b/src/plugins/discover/public/application/embeddable/search_embeddable.ts
@@ -308,9 +308,9 @@ export class SearchEmbeddable
     );
     if (useNewFieldsApi) {
       searchSource.removeField('fieldsFromSource');
-      const fields: Record<string, any> = { field: '*' };
+      const fields: Record<string, string> = { field: '*' };
       if (pre712) {
-        fields.include_unmapped = true;
+        fields.include_unmapped = 'true';
       }
       searchSource.setField('fields', [fields]);
     } else {

diff --git a/test/functional/apps/discover/_indexpattern_with_unmapped_fields.ts b/test/functional/apps/discover/_indexpattern_with_unmapped_fields.ts
@@ -22,8 +22,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
 
     before(async () => {
       await esArchiver.loadIfNeeded('unmapped_fields');
-      await kibanaServer.uiSettings.replace({ defaultIndex: 'test-index-unmapped-fields' });
-      await kibanaServer.uiSettings.update({
+      await kibanaServer.uiSettings.replace({
+        defaultIndex: 'test-index-unmapped-fields',
         'discover:searchFieldsFromSource': false,
       });
       log.debug('discover');

diff --git a/test/functional/fixtures/es_archiver/data/data.json.gz b/test/functional/fixtures/es_archiver/data/data.json.gz