Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile error #16

Closed
eaglgenes101 opened this issue Mar 3, 2021 · 3 comments
Closed

Compile error #16

eaglgenes101 opened this issue Mar 3, 2021 · 3 comments

Comments

@eaglgenes101
Copy link

When compiling a project that uses criterion, which has tinytemplate as a dependency, I get this compilation error when cargo tries to build it:

error: unknown `doc` attribute `Hidden`
  --> <SNIP>/tinytemplate-1.2.0/src/error.rs:44:11
   |
44 |     #[doc(Hidden)]
   |           ^^^^^^

error: aborting due to previous error

error: could not compile `tinytemplate`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed

My version of Cargo is cargo 1.52.0-nightly (572e20153 2021-02-24).
@cart
Copy link

cart commented Mar 3, 2021

Yup this just broke Bevy's test builds bevyengine/bevy#1313

@kitsuneninetails
Copy link

I also filed PR, only to see that a PR was already filed :).

@zbraniecki zbraniecki mentioned this issue Mar 3, 2021
Merged
@AurevoirXavier AurevoirXavier mentioned this issue Mar 3, 2021
Merged
@CPerezz CPerezz mentioned this issue Mar 3, 2021
Merged
@lenaschoenburg lenaschoenburg mentioned this issue Mar 3, 2021
Merged
@jdm jdm mentioned this issue Mar 3, 2021
Merged
@ljedrz ljedrz mentioned this issue Mar 3, 2021
Merged
@bheisler
Copy link
Owner

bheisler commented Mar 4, 2021

Thanks for the report! I've published a version 1.2.1 with the fix applied.

@bheisler bheisler closed this as completed Mar 4, 2021
This was referenced Mar 4, 2021
Merged
Merged
bors bot added a commit to rust-rosetta/rust-rosetta that referenced this issue Mar 5, 2021
@bors @efx
Merge #731
117a7b7 
731: `cargo update` to fix CI r=euclio a=efx

I ran `cargo update` to bump `tinytemplate` and include this fix:
bheisler/TinyTemplate#16

Co-authored-by: Eli Flanagan <efx@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bheisler @cart @eaglgenes101 @kitsuneninetails