Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unknown doc attribute Hidden at nightly #17

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Fix unknown doc attribute Hidden at nightly #17

merged 1 commit into from
Mar 3, 2021

Conversation

zzau13
Copy link
Contributor

@zzau13 zzau13 commented Mar 3, 2021

The Hidden doc attribute it's no longer valid at nightly

Stupremee referenced this pull request in rslint/rslint Mar 3, 2021
Brings down the crates to build, for `rslint-cli` to 119,
which was 150 before this commit.
@Robbepop
Copy link

Robbepop commented Mar 3, 2021

Also breaks my build. :(

   Compiling tinytemplate v1.2.0
error: unknown `doc` attribute `Hidden`
  --> /home/me/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/tinytemplate-1.2.0/src/error.rs:44:11
   |
44 |     #[doc(Hidden)]
   |           ^^^^^^

@@ -41,7 +41,7 @@ pub enum Error {
column: usize,
},

#[doc(Hidden)]
#[doc(hidden)]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that's what I'm fixing. Is there a problem with the cache on the CI?

Copy link

@paolobarbolini paolobarbolini Mar 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a problem with the cache on the CI?

criterion is being used as a dev-dependency, and it's importing this crate from crates.io.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, there is a cyclic dependency.

But this is a criterion bug nightly so it should be fixed from the criterion repository. From here I can't do anything. Remove dependency, little more.

It's just in the benchmarks I don't think it's important.

@Manishearth
Copy link

To be clear this is a rustc regression (rust-lang/rust#82662), and we hope to fix it in the next nightly (rust-lang/rust#82702), but until then it would be really great if this could be landed with a version bump

@bheisler bheisler merged commit 493a199 into bheisler:master Mar 3, 2021
@bheisler
Copy link
Owner

bheisler commented Mar 3, 2021

Thanks for the pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants