-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
total skipped and times details added #177
Conversation
Hi, can you please provide more details in MR description? Also, I'll close and reopen MR to see why checks do not run. |
Please add a new test case validating that the total number of skipped tests is correct. Existing test case have it at 0, which does not really check how merging should work. And I have a question about total time. I don't know how other tools work. Do they somehow take into account that tests may be running in parallel? Maybe adding all times up will not make sense? |
Adding a new test will require adding new test xml files and also a new expected merged report. Since the skipped count is just an extra tag that shows up in Let me know if that is not enough.
That is right. Just adding up the time wont make sense if it runs in parallel. I will remove that change |
Codecov Report
@@ Coverage Diff @@
## main #177 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 4 4
Lines 59 59
=======================================
Hits 58 58
Misses 1 1
Continue to review full report at Codecov.
|
@a-chatterjee , thank you for your work on this! Your changes have been included in v3.0.6 |
Junit report also shows skipped tests and time details for each test suite. The total of skipped tests or time taken are not being populated at the testsuites level.
all testing tools which generate a combined junit report by default, have the combined detail at the root testsuites level. Added them as part of attributes.