Skip to content

Commit

Permalink
Merge pull request #126 from franklin-feingold/master
Browse files Browse the repository at this point in the history
Update to Release_Protocol.md
  • Loading branch information
chrisgorgo authored Jan 14, 2019
2 parents 24474b7 + 0c93423 commit 78446d7
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Release_Protocol.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ When a release pull request is ready to be opened, please follow this procedure.

Please make sure your fork is the most up to date version

### 2. Change 'Unreleased' to the version number in the src/CHANGES.md file. One may commit this to their fork.
### 2. Change 'Unreleased' to the version number and change the path to the versioned readthedocs rendering in the src/CHANGES.md file. One may commit this to their fork.

This process is figured below ![Unreleased-to-Version](release_images/Unreleased-to-Version.png "Unreleased-to-Version")

Expand All @@ -15,7 +15,7 @@ Important note: The pull request title **needs** to follow this protocol. REL: v

### This will open a period of discussion for 5 business days regarding if we are ready to release. This will also freeze all pull request merging.

If we determine we are ready to release, please have the PR submitter add an additional commit with the date in year-month-date format in parentheses after the version of the date of merging (not opening) (i.e. it should read 1.1.2 (2018-12-28)) and merge this PR. This will mark a new release. On the same day, please also do a github release. To do this please see below.
If we determine we are ready to release, please have the PR submitter add an additional commit with the date in year-month-date format in parentheses after the version of the date of merging (not opening) (i.e. it should read v1.1.2 (2018-12-28)) and merge this PR. This will mark a new release. On the same day, please also do a github release. To do this please see below.

![GH-release-1](release_images/GH-release_1.png "GH-release-1")

Expand Down
Binary file modified release_images/GH-release_3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified release_images/Unreleased-to-Version.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 78446d7

Please sign in to comment.