Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto generate change log #3

Closed
chrisgorgo opened this issue Sep 28, 2018 · 8 comments
Closed

Auto generate change log #3

chrisgorgo opened this issue Sep 28, 2018 · 8 comments
Labels
enhancement New feature or request formatting Aesthetics and formatting of the spec help wanted Extra attention is needed

Comments

@chrisgorgo
Copy link
Contributor

Based on pull requests. Listed on github via releases.

@chrisgorgo chrisgorgo added enhancement New feature or request help wanted Extra attention is needed labels Sep 28, 2018
@chrisgorgo chrisgorgo added the formatting Aesthetics and formatting of the spec label Oct 2, 2018
patrick-g-h pushed a commit to patrick-g-h/bids-specification that referenced this issue Oct 22, 2018
@franklin-feingold
Copy link
Collaborator

Starting to work on this - @teonbrooks @choldgraf may you have any recommendations to create this automated solution? Any suggestions will be greatly appreciated!

@emdupre
Copy link
Collaborator

emdupre commented Nov 7, 2018

Have you already looked at release-drafter bot ?

EDIT: We use it in tedana -- you can see an example of its output here !

@franklin-feingold
Copy link
Collaborator

Thank you for the recommendation! This looks like a good option. It appears that it will output onto the releases tag? The hope is that the merged PR's will be automatically added to the CHANGES.md, with the CHANGES.md linked in the readthedocs.

@emdupre
Copy link
Collaborator

emdupre commented Nov 8, 2018

It will output to the release notes ! You can see them as a draft before the release, looking something like this:

screenshot from 2018-11-07 20-01-30

One thought: It looks like you're building your RTD site continuously, rather than only at releases. If that's true, then my concern would be that a continuously updating changelog (by directly adding merged PRs to a CHANGES.md) could yield confusion as to what is in the "beta" specification as opposed to the official release.

I think the solution used in other software such as FMRIPREP (and I know the solution we use in tedana) is to manually update the changelog at releases. But I'm not sure what your considerations are for minting a release, here !

@emdupre
Copy link
Collaborator

emdupre commented Nov 8, 2018

Actually, that's a broader issue, then, if any merged PRs are going live on the specification as soon as they're merged. Maybe the docs should only be built at releases ? Or I might just have totally misunderstood the current situation, sorry !

@chrisgorgo
Copy link
Contributor Author

RTD can distinguish between stable (latest tag) and latest (current master) which should solve the issue.

@emdupre
Copy link
Collaborator

emdupre commented Nov 8, 2018

Yes, I'd +1 having RTD build stable ! AFAICT that's not where we are currently, but it would make it much easier to keep track of changes between releases as PRs are merged in.

That being said, it won't solve your question @franklin-feingold, of having the CHANGES.md file automatically update as well. Manually pulling from the drafted release notes is one option, but there might be other, better ones !

@franklin-feingold
Copy link
Collaborator

Thank you for your explanation @emdupre ! Very useful to know about that tool and this possible solution moving forward. I will continue looking for other possible solutions that may update directly into the CHANGES.md file.

effigies referenced this issue in effigies/bids-specification Mar 6, 2019
[ENC] getting rid of type- key
effigies referenced this issue in effigies/bids-specification Nov 22, 2020
effigies pushed a commit that referenced this issue Feb 1, 2022
Inheritance principle: No unsetting as corollary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request formatting Aesthetics and formatting of the spec help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants