Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for how to update the specification with a BEP #96

Closed
choldgraf opened this issue Nov 26, 2018 · 10 comments · Fixed by #97 or #106
Closed

Instructions for how to update the specification with a BEP #96

choldgraf opened this issue Nov 26, 2018 · 10 comments · Fixed by #97 or #106

Comments

@choldgraf
Copy link
Collaborator

Is there a place with instructions for how to update the BIDS specification with a new BEP? I think we're ready to go soon with BIDS-iEEG, and wonder if we can use this as an opportunity to improve the docs around contributing to the markdown etc.

@emdupre
Copy link
Collaborator

emdupre commented Nov 26, 2018

I know there's the BIDS Contributor Guide -- I think we decided against putting this in the starter kit, though I can't quite remember why -- maybe @KirstieJane would know ?

Regardless, there's still a lot here that references google docs, and I'm not sure if the whole thing should be converted to Markdown !

@chrisgorgo
Copy link
Contributor

Indeed the Contributor Guide explains the procedure and has been updated a while ago to mention the need for sending a Pull Request with the BEP in Markdown form.

I think it is a great idea to improve the docs - starting from porting Contributor Guide to Markdown and incorporating it into this repo.

@choldgraf
Copy link
Collaborator Author

choldgraf commented Nov 27, 2018

As a first start, how about we add a section to the bids-specification docs for this, and just link to the google doc?

@chrisgorgo
Copy link
Contributor

Sounds good to me!

@emdupre
Copy link
Collaborator

emdupre commented Nov 27, 2018 via email

@choldgraf
Copy link
Collaborator Author

choldgraf commented Nov 27, 2018

Ahh I see it - IMO those could live in their own separate section so that they show up in the navbar on the left and are more discoverable that way. What if we:

  1. Made a section for "Extending the BIDS specification" at the end and move the current text there.
  2. Replace that text with a short description of the extension process and link out to the new page for more information.

(note that here I'm trying not to make the navbar title something like "BIDS Extensions" because I think it'll confuse people into thinking of "extension" as in "firefox or chrome extension" not as in "modifying the BIDS specification")

@emdupre
Copy link
Collaborator

emdupre commented Nov 27, 2018

I'd +1 having all of the BEPs (and the guide) as their own section from the navbar ! So that sounds good to me 👍

@emdupre
Copy link
Collaborator

emdupre commented Nov 28, 2018

It looks like the links added here aren't rendering correctly :(

https://bids-specification.readthedocs.io/en/latest/06-extensions.html

@choldgraf
Copy link
Collaborator Author

ahhh I bet it's because of the line break that I added to try and not violate line length limits...

@emdupre
Copy link
Collaborator

emdupre commented Nov 28, 2018

Should we re-open this issue, @chrisfilo ?

@chrisgorgo chrisgorgo reopened this Nov 28, 2018
sappelhoff added a commit to sappelhoff/bids-specification that referenced this issue Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants