-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Allow README file extensions. #1033
Conversation
Used REQUIRED for consistency with the schema.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1033 +/- ##
===========================================
+ Coverage 34.05% 71.50% +37.45%
===========================================
Files 8 9 +1
Lines 834 930 +96
===========================================
+ Hits 284 665 +381
+ Misses 550 265 -285 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another open question is whether we should allow these extension also for the LICENSE and CHANGES files.
given that CHANGES must follow CPAN convention, only .txt
may make sense as an extension.
Furthermore I don't know any license in MD or RST syntax, so here again .txt
might be the only meaningful extension near to the existing "no extension" convention.
WDYT?
I agree that we probably shouldn't update LICENSE or CHANGES given that they are more restrictive than README. If someone requests them in the future, we can revisit. |
I 1000% agree with this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly just non-consequential comments, with one concern -- why not to restrict .md to basic? I bet openneuro and other portals would prefer to render those .md files. If flavor is not regulated -- it would cause troubles, thus reducing the benefit from having .md to start with.
before I forget it @mateuszpawlik could you please add yourself to the contributors list here? https://github.com/bids-standard/bids-specification/wiki/Recent-Contributors We sync that wiki entry with the corresponding page in the BIDS specification before every new release. |
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
Added fogotten changes propagation to src/03-modality-agnostic-files.md
Thanks for this contribution @mateuszpawlik! |
Thank you all for making it happen. That was a nice experience :-) I'm looking forward to more. |
Closes #972
Tasks to complete:
bids-specification/src/schema/objects/top_level_files.yaml
Lines 24 to 26 in ba11771
bids-specification/src/schema/rules/top_level_files.yaml
Line 5 in ba11771
I kept the README description in the specification and in the schema equal. Maybe a macro could help not to need to update such definitions in two places.