Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Allow README file extensions. #1033

Merged
merged 8 commits into from
Apr 4, 2022

Conversation

mateuszpawlik
Copy link
Contributor

@mateuszpawlik mateuszpawlik commented Mar 21, 2022

Closes #972

Tasks to complete:

I kept the README description in the specification and in the schema equal. Maybe a macro could help not to need to update such definitions in two places.

@mateuszpawlik mateuszpawlik marked this pull request as ready for review March 21, 2022 12:00
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.50%. Comparing base (4a6c49a) to head (815c62e).
Report is 1460 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1033       +/-   ##
===========================================
+ Coverage   34.05%   71.50%   +37.45%     
===========================================
  Files           8        9        +1     
  Lines         834      930       +96     
===========================================
+ Hits          284      665      +381     
+ Misses        550      265      -285     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another open question is whether we should allow these extension also for the LICENSE and CHANGES files.

given that CHANGES must follow CPAN convention, only .txt may make sense as an extension.

Furthermore I don't know any license in MD or RST syntax, so here again .txt might be the only meaningful extension near to the existing "no extension" convention.

WDYT?

@tsalo
Copy link
Member

tsalo commented Mar 22, 2022

I agree that we probably shouldn't update LICENSE or CHANGES given that they are more restrictive than README. If someone requests them in the future, we can revisit.

@Remi-Gau
Copy link
Collaborator

I agree that we probably shouldn't update LICENSE or CHANGES given that they are more restrictive than README. If someone requests them in the future, we can revisit.

I 1000% agree with this

Copy link
Collaborator

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly just non-consequential comments, with one concern -- why not to restrict .md to basic? I bet openneuro and other portals would prefer to render those .md files. If flavor is not regulated -- it would cause troubles, thus reducing the benefit from having .md to start with.

src/03-modality-agnostic-files.md Show resolved Hide resolved
src/schema/objects/top_level_files.yaml Outdated Show resolved Hide resolved
src/schema/objects/top_level_files.yaml Outdated Show resolved Hide resolved
src/03-modality-agnostic-files.md Show resolved Hide resolved
@sappelhoff
Copy link
Member

before I forget it @mateuszpawlik could you please add yourself to the contributors list here? https://github.com/bids-standard/bids-specification/wiki/Recent-Contributors

We sync that wiki entry with the corresponding page in the BIDS specification before every new release.

Added fogotten changes propagation to src/03-modality-agnostic-files.md
@sappelhoff sappelhoff merged commit ee9e8b5 into bids-standard:master Apr 4, 2022
@sappelhoff
Copy link
Member

Thanks for this contribution @mateuszpawlik!

@mateuszpawlik
Copy link
Contributor Author

Thank you all for making it happen. That was a nice experience :-) I'm looking forward to more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow extension for the README file
5 participants