Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] allow for .png and .tif in eeg/ieeg/meg as allowed for micr #1049

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

yarikoptic
Copy link
Collaborator

@yarikoptic yarikoptic commented Mar 31, 2022

Discovered while working on #1047

I guess it could be argued against but I feel that such unification makes sense. There might be other common suffixes where we might want to introduce similar unification.

@yarikoptic yarikoptic requested a review from tsalo as a code owner March 31, 2022 18:26
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.50%. Comparing base (7ec7450) to head (280074a).
Report is 1435 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1049      +/-   ##
==========================================
+ Coverage   70.53%   71.50%   +0.96%     
==========================================
  Files           9        9              
  Lines         930      930              
==========================================
+ Hits          656      665       +9     
+ Misses        274      265       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really remember why this was restricted to JPG to begin with. Probably to limit the amount of possible extensions ... as we also did with e.g., EEG file formats.

I don't think the suggestion here would hurt anyone.

@effigies
Copy link
Collaborator

effigies commented Apr 2, 2022

Might be good to check in with all the *EG BEP leads.

Copy link
Collaborator

@robertoostenveld robertoostenveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense, also for consistency.

Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me too

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sappelhoff sappelhoff added MEG Magnetoencephalography iEEG EEG Electroencephalography enhancement New feature or request labels Apr 11, 2022
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the schema's perspective, this looks good to me. I leave it up to others to approve the content change.

@effigies
Copy link
Collaborator

Looks like lots of approval and no dissent. I agree that there doesn't seem to be much benefit in keeping this restricted, as all proposed formats are well-supported (though TIFF is more a container than a codec, I think we can assume people aren't doing really wild things with it).

@effigies
Copy link
Collaborator

15 days since last change, 7 days since 2 approvals, no objections since then. Merging.

@effigies effigies merged commit 7e16903 into bids-standard:master Apr 15, 2022
@sappelhoff sappelhoff changed the title ENH: allow for .png and .tif in eeg/ieeg/meg as allowed for micr [ENH] allow for .png and .tif in eeg/ieeg/meg as allowed for micr Jul 27, 2022
@yarikoptic yarikoptic deleted the bf-photo-exts branch April 30, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EEG Electroencephalography enhancement New feature or request iEEG MEG Magnetoencephalography
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants