[ENH] State of the schema sprint #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Christopher J. Markiewicz <markiewicz@stanford.edu>
[SCHEMA] Define YAML tables for MRI common metadata fields and anatomy data
* Draft ASL and DWI metadata table rules. * Add description addendum. * Define metadata for the behavioral modality. * Whoops, separate beh and continuous data. * Add EEG. * Add iEEG. * Fix. * Add microscopy. * Split up the existing sidecars file. * Fix issues. * Update micr.yaml * Update entities.yaml
Squashed commit of the following: commit ee5ff05 Author: anthony galassi <28850131+bendhouseart@users.noreply.github.com> Date: Thu Apr 7 15:48:02 2022 -0400 moved pet stuff to src/schema/rules/sidecars/pet.yaml commit d00e683 Author: Anthony Galassi <28850131+bendhouseart@users.noreply.github.com> Date: Fri Mar 18 09:40:55 2022 -0400 Update src/schema/rules/sidecars.yml commit 928eea2 Author: Anthony Galassi <28850131+bendhouseart@users.noreply.github.com> Date: Thu Mar 17 15:42:10 2022 -0400 Add backticks Added backticks commit 50b0ae0 Author: anthony galassi <28850131+bendhouseart@users.noreply.github.com> Date: Tue Mar 15 12:34:42 2022 -0400 fixed level addendum's, removed quotes for selector in PETMRISequenceSpecifics to make linter happy commit 4a177c0 Author: anthony galassi <28850131+bendhouseart@users.noreply.github.com> Date: Mon Mar 14 15:59:54 2022 -0400 fixed n - 1 yaml errors, 1 remaining commit 6e40318 Author: Anthony Galassi <28850131+bendhouseart@users.noreply.github.com> Date: Mon Mar 14 15:49:29 2022 -0400 Update src/schema/rules/sidecars.yml change addendum -> level_addendum per commit suggestion. Co-authored-by: Taylor Salo <tsalo006@fiu.edu> commit a4fb377 Merge: 41bc816 c5f89c6 Author: Anthony Galassi <28850131+bendhouseart@users.noreply.github.com> Date: Mon Mar 14 15:17:00 2022 -0400 Merge branch 'schema/sidecar_validation' into bendhouseart-tables commit 41bc816 Author: anthony galassi <28850131+bendhouseart@users.noreply.github.com> Date: Thu Mar 10 15:49:58 2022 -0500 fixed yaml formatting
* Add MEG. * Add fmap file. * Add func file. * Fix a couple of things. * Update func.yaml
…ator Issues google sheet
[SCHEMA] Conform the schema/rules files consistently
…cation into schema/common_derivatives
…g derivatives add missing comma in tabular common_derivatives
[RTM] SCHEMA: Encode requirement levels for dataset_description and genetic_info
Remi-Gau
reviewed
Apr 19, 2022
Comment on lines
+25
to
+32
| GeneratedBy[].Name: REQUIRED | ||
| GeneratedBy[].Version: RECOMMENDED | ||
| GeneratedBy[].Description: OPTIONAL | ||
| GeneratedBy[].CodeURL: OPTIONAL | ||
| GeneratedBy[].Container: OPTIONAL | ||
| GeneratedBy[].Container{}.Type: RECOMMENDED | ||
| GeneratedBy[].Container{}.Tag: RECOMMENDED | ||
| GeneratedBy[].Container{}.URI: RECOMMENDED |
There was a problem hiding this comment.
Those dot, brackets and curly braces will MATLAB cry: the only special characters allowed in keys by matlab are _
Related to
#1082
There was a problem hiding this comment.
We need some way to mark the requirement levels of sub objects.
There was a problem hiding this comment.
#841 is really just an artifact at this point. Once someone (probably me) writes a function to render subobjects in tables, we can get rid of the Genetics.* fields.
This reverts commit d9e38fa.
…cation into schema/common_derivatives
[SCHEMA] Define common derivatives rules
SCHEMA convert selectors and checks to javascript
|
Three live 👍s. Merging to avoid accumulating merge conflicts. |
bids-maintenance
added a commit
that referenced
this pull request
Apr 28, 2022
sappelhoff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly doing this to get an RTD pull request build going as we update.