Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Discourage use of "sample" in events if sampling frequency is ambiguous, add guidelines for precision #1140

Merged
merged 4 commits into from
Jul 22, 2022

Conversation

sappelhoff
Copy link
Member

closes #1043

Adds two minor tweaks to our documentation of events.tsv:

  1. Don't Use sample when the sampling frequency in the raw data is ambiguous / mixed
  2. Use a reasonable precision for numeric metadata (onset, duration, response_time, ...)

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #1140 (2692bf5) into master (7172921) will increase coverage by 2.90%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1140      +/-   ##
==========================================
+ Coverage   75.18%   78.08%   +2.90%     
==========================================
  Files          11       11              
  Lines        1362     1378      +16     
==========================================
+ Hits         1024     1076      +52     
+ Misses        338      302      -36     
Impacted Files Coverage Δ
...ools/schemacode/schemacode/tests/test_validator.py 100.00% <0.00%> (ø)
tools/schemacode/schemacode/_version.py 38.90% <0.00%> (+2.59%) ⬆️
tools/schemacode/schemacode/validator.py 92.13% <0.00%> (+9.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07741e7...2692bf5. Read the comment docs.

Copy link
Member

@VisLab VisLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good.

Also suggest changing "referred" to "referenced" on line 70.

Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
@sappelhoff sappelhoff added this to the 1.8.0 milestone Jul 20, 2022
@effigies effigies merged commit 3f88d17 into bids-standard:master Jul 22, 2022
@sappelhoff sappelhoff deleted the fix/sample/events branch July 22, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request clarification on the meaning of "sample"
4 participants