Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MISC] Remove label format and inheritance principle redundancies in fMRI section #1197

Merged
merged 2 commits into from
Aug 15, 2022
Merged

[MISC] Remove label format and inheritance principle redundancies in fMRI section #1197

merged 2 commits into from
Aug 15, 2022

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Aug 12, 2022 •
edited
Loading

relates to #1194

Remi-Gau
Remi-Gau commented Aug 12, 2022
View reviewed changes
src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md
Comment on lines -493 to -495
Each task has a unique label that MUST only consist of letters and/or numbers
(other characters, including spaces and underscores, are not allowed) with the
[`task-<label>`](../99-appendices/09-entities.md#task) entity.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

label format is defined in common principles

Remi-Gau
Remi-Gau commented Aug 12, 2022
View reviewed changes
src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md
@@ -703,14 +700,6 @@ A guide for using macros can be found at
}
```

If this information is the same for all participants, sessions and runs it can
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restate inheritance principle

tsalo
tsalo approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the PR title should be updated, though, given the limited scope of your changes.

@Remi-Gau Remi-Gau changed the title [REF] Remove redundancies [REF] Remove label format and inheritane principle redundancies in fMRI section Aug 12, 2022
@Remi-Gau
Copy link
Collaborator Author

LGTM. I think the PR title should be updated, though, given the limited scope of your changes.

Good point. Just changed it.

@sappelhoff sappelhoff changed the title [REF] Remove label format and inheritane principle redundancies in fMRI section [MISC] Remove label format and inheritane principle redundancies in fMRI section Aug 15, 2022
@sappelhoff sappelhoff merged commit 1800e3a into bids-standard:master Aug 15, 2022
bids-maintenance added a commit that referenced this pull request Aug 15, 2022
@bids-maintenance
[DOC] Auto-generate changelog entry for PR #1197
cde159d
@Remi-Gau Remi-Gau deleted the redundancy branch August 17, 2022 07:19
@tsalo tsalo changed the title [MISC] Remove label format and inheritane principle redundancies in fMRI section [MISC] Remove label format and inheritance principle redundancies in fMRI section Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sappelhoff sappelhoff sappelhoff approved these changes

@tsalo tsalo tsalo approved these changes

@chrisgorgo chrisgorgo Awaiting requested review from chrisgorgo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Remi-Gau @tsalo @sappelhoff