Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MISC] Clarify: FieldMap PE technique --> no SPM #1253

Merged
merged 2 commits into from
Sep 1, 2022
Merged

[MISC] Clarify: FieldMap PE technique --> no SPM #1253

merged 2 commits into from
Sep 1, 2022

Conversation

CPernet
Copy link
Collaborator

@CPernet CPernet commented Aug 25, 2022

SPM doesn't deal with that case

@CPernet CPernet requested review from gllmflndn and Remi-Gau and removed request for chrisgorgo August 25, 2022 10:03
Remi-Gau
Remi-Gau approved these changes Aug 25, 2022
View reviewed changes
Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK you are correct @CPernet.

@gllmflndn can you confirm?

If you need context:

https://bids-specification.readthedocs.io/en/latest/04-modality-specific-files/01-magnetic-resonance-imaging-data.html#case-4-multiple-phase-encoded-directions-pepolar

@CPernet @tsalo
Update src/04-modality-specific-files/01-magnetic-resonance-imaging-d…
01c98a3 
…ata.md

Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
effigies
effigies approved these changes Aug 31, 2022
View reviewed changes
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems no less correct, regardless of what SPM can do.

@sappelhoff sappelhoff changed the title FieldMap PE technique - no SPM [MISC] Clarify: FieldMap PE technique --> no SPM Sep 1, 2022
@sappelhoff sappelhoff merged commit 0c7ed2c into master Sep 1, 2022
@sappelhoff sappelhoff deleted the CPernet-patch-1 branch September 1, 2022 11:09
@sappelhoff
Copy link
Member

Thanks @CPernet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsalo tsalo tsalo left review comments

@effigies effigies effigies approved these changes

@Remi-Gau Remi-Gau Remi-Gau approved these changes

@gllmflndn gllmflndn Awaiting requested review from gllmflndn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CPernet @sappelhoff @effigies @Remi-Gau @tsalo