Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Update to Release_Protocol.md #126

Merged
merged 3 commits into from
Jan 14, 2019
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Release_Protocol.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ When a release pull request is ready to be opened, please follow this procedure.

Please make sure your fork is the most up to date version

### 2. Change 'Unreleased' to the version number in the src/CHANGES.md file. One may commit this to their fork.
### 2. Change 'Unreleased' to the version number and change the path 'HEAD' to the version number in the src/CHANGES.md file. One may commit this to their fork.

This process is figured below ![Unreleased-to-Version](release_images/Unreleased-to-Version.png "Unreleased-to-Version")

Expand All @@ -15,7 +15,7 @@ Important note: The pull request title **needs** to follow this protocol. REL: v

### This will open a period of discussion for 5 business days regarding if we are ready to release. This will also freeze all pull request merging.

If we determine we are ready to release, please have the PR submitter add an additional commit with the date in year-month-date format in parentheses after the version of the date of merging (not opening) (i.e. it should read 1.1.2 (2018-12-28)) and merge this PR. This will mark a new release. On the same day, please also do a github release. To do this please see below.
If we determine we are ready to release, please have the PR submitter add an additional commit with the date in year-month-date format in parentheses after the version of the date of merging (not opening) (i.e. it should read v1.1.2 (2018-12-28)) and merge this PR. This will mark a new release. On the same day, please also do a github release. To do this please see below.

![GH-release-1](release_images/GH-release_1.png "GH-release-1")

Expand Down
Binary file modified release_images/GH-release_3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified release_images/Unreleased-to-Version.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.