Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Remove redundant entity definitions on MRI page #1265

Merged
merged 10 commits into from
Sep 6, 2022

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Aug 30, 2022

Related to #612.

This PR removes any paragraphs describing entities, wherein the description does not differ appreciably from, or expand upon, the official entity definition in the schema, from the MRI page.

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #1265 (a25114a) into master (8b53807) will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1265      +/-   ##
==========================================
+ Coverage   87.95%   88.18%   +0.22%     
==========================================
  Files           6        6              
  Lines        1038     1041       +3     
==========================================
+ Hits          913      918       +5     
+ Misses        125      123       -2     
Impacted Files Coverage Δ
tools/schemacode/bidsschematools/render.py 92.56% <100.00%> (+0.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tsalo tsalo marked this pull request as ready for review August 31, 2022 18:15
@tsalo tsalo requested review from Remi-Gau and sappelhoff and removed request for erdalkaraca and chrisgorgo August 31, 2022 18:15
Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for this refactoring @tsalo

Had a quick look I think that there may be a paragraph or 2 we could similarly remove from PET or microscopy in another PR.

@tsalo
Copy link
Member Author

tsalo commented Sep 1, 2022

Had a quick look I think that there may be a paragraph or 2 we could similarly remove from PET or microscopy in another PR.

Absolutely! I definitely want to work through the rest of the spec to remove anything unnecessary.

@sappelhoff sappelhoff added this to the 1.8.0 milestone Sep 1, 2022
@sappelhoff sappelhoff merged commit ce5c05d into bids-standard:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants