[MISC] allow for any "recording" file to be listed in _scans.tsv not just "neural recording" #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al recording" I think this would be more appropriate since we could have _beh and other files with their acq_time. I kept it as "recording file" (not e.g. just "data file") to keep better alignment with acq_time name of the column. So could also be "acquisition time" instead of "recording time".
Remi-Gau
approved these changes
Dec 9, 2022
bids-maintenance
added a commit
that referenced
this pull request
Dec 13, 2022
sappelhoff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this would be more appropriate since we could have _beh and other files with their acq_time. I kept it as "recording file" (not e.g. just "data file") to keep better alignment with acq_time name of the column.
So could also be "acquisition time" instead of "recording time".