Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add version list to schema.meta and a warning on unknown BIDSVersion #1472

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

effigies
Copy link
Collaborator

Fixes bids-standard/bids-validator#1403 in the schema.

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cfe35f7) 87.88% compared to head (a17b4dd) 87.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1472   +/-   ##
=======================================
  Coverage   87.88%   87.88%           
=======================================
  Files          14       14           
  Lines        1279     1279           
=======================================
  Hits         1124     1124           
  Misses        155      155           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@effigies effigies merged commit 3d00184 into bids-standard:master Apr 28, 2023
@sappelhoff sappelhoff added the exclude-from-changelog This item will not feature in the automatically generated changelog label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn when BIDSVersion exceeds latest version at time of release
3 participants