-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Remove references to unspecified aslcontext.json #1485
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1485 +/- ##
=======================================
Coverage 87.75% 87.75%
=======================================
Files 14 14
Lines 1282 1282
=======================================
Hits 1125 1125
Misses 157 157 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me, except for the wording of the paragraph about the asllabeling file.
Co-authored-by: Taylor Salo <tsalo90@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion and an additional suggestion for a follow-up PR.
An anonymized screenshot of the planning of the labeling slab/plane | ||
with respect to the imaging slab or slices. | ||
This screenshot is based on DICOM macro C.8.13.5.14. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going to copy directly from the schema, it would be better to move to something like:
{{ MACROS_render_text("objects.suffixes.asllabeling.description") }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean creating a new macro then, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this relates to this:
#1038
I would suggest we wait for some ASL BEP lead to also approve this before merging. |
@patsycle @HenkMutsaerts In case you missed the review request... |
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
fixes #1479