Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Recommend SliceTiming if MRAcquisitionType is "2D" #1594

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Aug 24, 2023

Closes #1585.

Changes proposed:

  • Create new rule, SliceTimingMRI, making SliceTiming a recommended field for MRI scans with MRAcquisitionType set to 2D. This way, SliceTiming is no longer recommended for 3D acquisitions.

@tsalo tsalo added schema Issues related to the YAML schema representation of the specification. Patch version release. MRI For things that affect all MRI datatypes labels Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d5b3d23) 87.83% compared to head (2e5434a) 87.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1594   +/-   ##
=======================================
  Coverage   87.83%   87.83%           
=======================================
  Files          16       16           
  Lines        1356     1356           
=======================================
  Hits         1191     1191           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straight forward enough

@effigies effigies merged commit 466e212 into bids-standard:master Sep 22, 2023
18 checks passed
@tsalo tsalo deleted the slicetiming-level branch September 26, 2023 13:37
@sappelhoff sappelhoff changed the title Recommend SliceTiming if MRAcquisitionType is "2D" [FIX] Recommend SliceTiming if MRAcquisitionType is "2D" Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MRI For things that affect all MRI datatypes schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SliceTiming for 3D acquisitions
3 participants