Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add optional low_cutoff and high_cutoff columns for fnirs channels.tsv #1597

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Aug 24, 2023

makes it consistent with what is done in EEG, iEEG, MEG

See the HTML table here

@rob-luke @lpollonini does this make sense to you

Closes bids-standard/bids-examples#396.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (48a61a6) 87.83% compared to head (c612a1b) 87.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1597   +/-   ##
=======================================
  Coverage   87.83%   87.83%           
=======================================
  Files          16       16           
  Lines        1356     1356           
=======================================
  Hits         1191     1191           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies changed the title [ENH] add optional filters columns for fnirs channels.tsv [ENH] Add optional low_cutoff and high_cutoff columns for fnirs channels.tsv Aug 25, 2023
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems obviously right, given that examples submitted by the BEP leads include them, and there is a clear interpretation. Adding these will not invalidate or increase validator noise on any datasets, so I vote for merge after the usual 5 days, regardless of whether we hear back.

@Remi-Gau
Copy link
Collaborator Author

Seems obviously right, given that examples submitted by the BEP leads include them, and there is a clear interpretation. Adding these will not invalidate or increase validator noise on any datasets, so I vote for merge after the usual 5 days, regardless of whether we hear back.

good with me

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

Copy link
Collaborator

@lpollonini lpollonini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes total sense. Approved!

@effigies
Copy link
Collaborator

Going to invoke rule 5 and merge now, as it will eliminate a spurious validator error.

@effigies effigies merged commit 6246705 into bids-standard:master Aug 25, 2023
19 checks passed
@Remi-Gau Remi-Gau deleted the filter_fnirs branch September 7, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

low_cutoff and high_cutoff columns in fnirs_tapping
4 participants