Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] make MEG section headings and ToC consistent to the EEG and iEEG specs #181

Merged
merged 2 commits into from
Apr 3, 2019

Conversation

robertoostenveld
Copy link
Collaborator

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Robert - two comments from my side:

  1. see Chris' comment: https://github.com/bids-standard/bids-specification/pull/181/files#r266490960
  2. Wouldn't it be better to have these changes as part of your PR [FIX] make section headings and ToC consistent between meg and eeg specs #180 ?

@robertoostenveld
Copy link
Collaborator Author

Thanks Robert - two comments from my side:

  1. see Chris' comment: https://github.com/bids-standard/bids-specification/pull/181/files#r266490960

Agreed. I propose to change it to <ext>. Traveling right now, so will have to wait a bit (or you can do it).

  1. Wouldn't it be better to have these changes as part of your PR [FIX] make section headings and ToC consistent between meg and eeg specs #180 ?

I wanted to keep ieeg and meg changes separate (since different people might want to review the respective changes.

@sappelhoff sappelhoff changed the title made section headings and ToC consistent with eeg and ieeg specification [FIX] make section headings and ToC consistent between eeg and ieeg specs Mar 19, 2019
@sappelhoff
Copy link
Member

Agreed. I propose to change it to . Traveling right now, so will have to wait a bit (or you can do it).

+1, however I don't have write access to your repo

image

but it's okay to wait with it for a few days

@robertoostenveld robertoostenveld changed the title [FIX] make section headings and ToC consistent between eeg and ieeg specs [FIX] make MEG section headings and ToC consistent to the EEG and iEEG specs Mar 27, 2019
@robertoostenveld robertoostenveld added MEG Magnetoencephalography formatting Aesthetics and formatting of the spec labels Mar 27, 2019
@sappelhoff sappelhoff merged commit cacd627 into bids-standard:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatting Aesthetics and formatting of the spec MEG Magnetoencephalography
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants