[FIX] change file for definition of electrical stimulation labels from _electrodes.json to _events.json

[ezemikulan]

closes #184

The text mentioned that the description of the electrical_stimulation_<label> columns had to be placed on _electrodes.json, but it should be placed on _events.json.

This PR fixes the issue.

[dorahermes]

thanks! lgtm

[chrisgorgo]

@ezemikulan if you want you can add your name to https://github.com/bids-standard/bids-specification/blob/master/src/99-appendices/01-contributors.md AND your github id to https://github.com/bids-standard/bids-specification/blob/master/CODEOWNERS

[ezemikulan]

@chrisfilo yes, I'll add it, thanks

[choldgraf]

nice! thanks for noticing @ezemikulan :-)

@chrisfilo bugfixes don't fall under the governance rules of the org, right?

[chrisgorgo]

All PRs are treated the same way, with the exception of new releases (which require additional approval from a Maintainer). A triage system could be put in place in the future, but is not currently part of decision-making rules.

However, if you want this PR to be merged now without having to wait 5 days to gain community exposure a Maintainer (@sappelhoff) has the power to merge it as is.

[choldgraf]

I think we should clarify this in the governance docs, either:

1. The waiting period only applies to changes that actually change the content of the spec, not that clarify or de-bug the language

or

2. One or a subset of individuals has the authority to override the governance at their discretion.

In its current state if governance says "every PR needs 5 days of comment" (or whatever amount), then we should follow it.

[chrisgorgo]

1. One or a subset of individuals has the authority to override the governance at their discretion.

I believe this is pretty clear in the recently added point 5 of the rules: https://github.com/bids-standard/bids-specification/blob/master/DECISION-MAKING.md#rules

If something is not clear or you would like to propose a triage system, please open a new issue or send a PR. This PR is not the best place to discuss this (most people will miss it).

[choldgraf]

cool, that looks fine to me, I'm happy with @sappelhoff merging

[sappelhoff]

thanks @ezemikulan!