Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Add bep006 and bep010 to completed beps and fix links #186

Merged
merged 4 commits into from
Mar 28, 2019

Conversation

sappelhoff
Copy link
Member

This PR is about the two big tables about extensions (active and completed): https://bids-specification.readthedocs.io/en/stable/06-extensions.html

For the active ones:

  • I removed duplicate links.
  • I added @jasmainak as a moderator for bep021 (was missing before albeit doing most of the moderation)

For the completed ones:

  • I added EEG and iEEG to the list.

Throughout, there are also some whitespace and link fixes (e.g., removing "sharing info" from a Google Doc link)

| [BEP023](https://docs.google.com/document/d/1yzsd1J9GT-aA0DWhdlgNr5LCu6_gvbjLyfvYq2FuxlY) | [PET Preprocessing derivatives](https://docs.google.com/document/d/1yzsd1J9GT-aA0DWhdlgNr5LCu6_gvbjLyfvYq2FuxlY) | Martin Noergaard, Graham Searle, Melanie Ganz |
| [BEP024](https://docs.google.com/document/d/1fqnJZ18x5LJC8jiJ8yvPHUGFzNBZ6gW2kywYrUKWtuo) | [Computed Tomography scan (CT)](https://docs.google.com/document/d/1fqnJZ18x5LJC8jiJ8yvPHUGFzNBZ6gW2kywYrUKWtuo) | Hugo Boniface |
| [BEP025](https://docs.google.com/document/d/1chZv7vAPE-ebPDxMktfI9i1OkLNR2FELIfpVYsaZPr4) | [Medical Population Imaging Data structure (MIDS)](https://docs.google.com/document/d/1chZv7vAPE-ebPDxMktfI9i1OkLNR2FELIfpVYsaZPr4) | Jose Manuel Saborit Torres |
| [BEP026](https://docs.google.com/document/d/14KC1d5-Lx-7ZSMtwS7pVAAvz-2WR_uoo5FvsNirzqJw) | [Microelectrode Recordings (MER)](https://docs.google.com/document/d/14KC1d5-Lx-7ZSMtwS7pVAAvz-2WR_uoo5FvsNirzqJw) | Greydon Gilmore |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may have some unintended conflicts with the derivatives merge due to the mismatch of this file. I don't want to add more challenges to that PR. Perhaps after that is merged this can be merged? Thank you for putting together this PR nonetheless!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean - thanks: I wasn't aware that there are lots of changes in the derivatives PR

https://github.com/bids-standard/bids-specification/pull/109/files#diff-2a8145214cd54ad2715d4543399df795

I guess @chrisfilo can make the call whether we should wait with this or we can go on with it, because he'd be the one who'd have to rebase the derivatives PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not recommend any PR to wait for #109. I am syncing it with master on a regular basis and will deal with any conflicts.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given @chrisfilo's comment, could you review/approve once more @franklin-feingold ?

also: @jasmainak perhaps you could give this a quick glance. It's nothing special, but I am adding your name as a moderator of BEP021, so this is your chance to protest or approve :-)

or protestingly approve

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you know the perils of asking me to review :-) do we have renewed interest in BEP021? so far I have just been replying to people ... maybe we can look at it once the iEEG/EEG publications go through!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do have interest in BEP021, but I also think we should gather some more experience with EEG and iEEG before moving on with 100% force ;-)

re: your review of this PR: Could you make use of the GitHub tool and approve (or disapprove)? We have community guidlines (and GH settings) here that require that as a formality.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sappelhoff sappelhoff merged commit ae08998 into bids-standard:master Mar 28, 2019
@sappelhoff sappelhoff deleted the addbeps branch March 28, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants