fix(schema): Add issue definitions for all checks #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
added
schema
|
@bendichter Just want to say that the metaschema has been such a helpful tool. Thanks so much for starting us down this road! |
effigies
force-pushed
the
fix/check-issues
branch
from
86142a3
to
02049c5
Compare
rwblair
approved these changes
Aug 8, 2024
nellh
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks need to define their own error codes. Updated the metaschema to enforce this and then fleshed them out.
@rob-luke If you wouldn't mind having a look over the NIRS checks? I'm pretty sure I got the intent correct, from re-reading the spec.