-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] update contributors #1964
base: master
Are you sure you want to change the base?
Conversation
Remi-Gau
commented
Oct 20, 2024
•
edited
Loading
edited
- companion PR to bids website [ENH] retrieve metadata BEP leads from BIDS contributors bids-website#476
- some BEP leads were not listed in contributors
- move all emails of BEP leads from the BIDS website to citation.cff of the spec to have only one instance of them
- add new contributors from some BEP
- add contributors who contributed to some tools
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1964 +/- ##
=======================================
Coverage 86.87% 86.87%
=======================================
Files 16 16
Lines 1410 1410
=======================================
Hits 1225 1225
Misses 185 185 ☔ View full report in Codecov by Sentry. |
b999731
to
ee61888
Compare
3626e29
to
e10d2d1
Compare
converting to draft:
|
TODO (but for future PRs):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -55,13 +56,14 @@ If you contributed to the BIDS ecosystem and your name is not listed, please add | |||
| Alexander Jones | 💻🐛 | | |||
| Alexander L. Cohen | 🐛💻📖💬 | | |||
| Alexander von Lautz | 📖 | | |||
| Alexandre D'Astous | 📖 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hypothesis: Alexandre was added only to the text file here in https://github.com/bids-standard/bids-specification/pull/1690/files but never to any of the "metadata" files for contributors. Thus whenever regenerated -- disappeared? So needs to gain a record in .tributors and .all-contributorsrc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I am pretty sure this it what happened: will fix
], | ||
"email": "mathieu.guay-paquet@polymtl.ca", | ||
"github": "mguaypaq", | ||
"name": "mathieu_guay-paquet" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surely:
"name": "mathieu_guay-paquet" | |
"name": "Mathieu Guay-Paquet" |
@@ -46,7 +46,7 @@ | |||
# update with your GitHub username and path to a file with GitHub token | |||
UPDATE_AVATARS = False | |||
GH_USERNAME = "Remi-Gau" | |||
TOKEN_FILE = None | |||
TOKEN_FILE = "/home/remi/Documents/tokens/gh_user.txt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no absolute paths should be hardcoded IMHO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should there be an env var or alike to define it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably unless the API calls done in here can be all handled be handled by the github CLI package (not sure)
For reviewing purposes, |
Yes the tributors is meant to be the ground truth and everything else should be generated form that. |
I want to get back to this one tomorrow to try to wrap it up. |