Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Trivial column header fix #220

Merged
merged 3 commits into from
May 9, 2019

Conversation

nicholst
Copy link
Collaborator

@nicholst nicholst commented May 6, 2019

Replace underscore-separated column headers with capitalised, space-separated headers.

Just fixing some snake-case formatted column labels (modality_label & contrast_label).

@nicholst nicholst requested a review from chrisgorgo as a code owner May 6, 2019 15:03
@nicholst
Copy link
Collaborator Author

nicholst commented May 6, 2019

If matching the original label string was intentional, then I'd recommend making it 'code' text, as in modality_label instead of modality_label and contrast_label instead of contrast_label.

Copy link
Contributor

@chrisgorgo chrisgorgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a typo. Those names correspond verbatim to a placeholder name in respective file name templates. Maybe adding brackets to the header name would make it more clear.

@chrisgorgo
Copy link
Contributor

If matching the original label string was intentional, then I'd recommend making it 'code' text, as in modality_label instead of modality_label and contrast_label instead of contrast_label.

Sounds good to me.

@nicholst
Copy link
Collaborator Author

nicholst commented May 6, 2019

Done! Now just changes the font.

@chrisgorgo
Copy link
Contributor

chrisgorgo
chrisgorgo previously approved these changes May 7, 2019
@nicholst
Copy link
Collaborator Author

nicholst commented May 7, 2019

Lint should be happy now.

@effigies effigies merged commit 07a8965 into bids-standard:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants