-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INFRA] Enable version panel for quickly finding previous versions #232
Conversation
ba815c5
to
450bf72
Compare
Some notes so I can close a ton of tabs:
|
I found a project using mkdocs-material and that has the panel: https://mapstore.readthedocs.io/ |
Found via geosolutions-it/MapStore2#3570, we need to add JQuery. We now get I'm going to squash this and merge into master. |
Apparently I can't push fixes to master. Here's to more changelog clutter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great effort, thanks @effigies.
Regarding pushing to master: Is your idea that all INFRA changes should be pushed directly to master instead of taking our usual road of going via a PR (see rule 1. in decision-making)?
I don't see an issue with having INFRA PRs in our changelog, but would be happy to discuss it.
I think there should be two changelogs: the repository changelog and the specification changelog. When somebody's reading the spec, what they care about is what new features are there in the specification, and absolutely not what changes were made to the build system. IMO, the specification changelog should ONLY include |
+1, perhaps you can open an issue on this, because this PR will be merged soon and is a suboptimal place for discussion. Related: #164 |
Just a note that I'm playing with trying to get RTD to play nicely.
In our builds, it acts as if there's no configuration file (example):
First thing I'm trying is to fix our configuration, and will host the results at https://bids-specification.readthedocs.io/en/rtdtest/ when I can get it to build.
Replaces #231.
closes #228