[FIX] remove ManufacturersAmplifierModelName (again) #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
robertoostenveld
commented
May 23, 2019
robertoostenveld
commented
- this was discussed in the past and supposed to be already removed in version https://github.com/bids-standard/bids-specification/blob/master/src/CHANGES.md#111 but apparently slipped through
- it is documented in the text properly, where it states "Note that if EEG is recorded with a separate amplifier, it should be stored separately under a new /eeg data type"
- this was discussed in the past and supposed to be already removed in version https://github.com/bids-standard/bids-specification/blob/master/src/CHANGES.md#111 but apparently slipped through - it is documented in the text properly, where it states "Note that if EEG is recorded with a separate amplifier, it should be stored separately under a new /eeg data type"
robertoostenveld
requested review from
choldgraf,
arnodelorme,
CPernet,
dorahermes and
sappelhoff
sappelhoff
approved these changes
May 23, 2019
|
to confirmations and this LGTM so merging away! |
franklin-feingold
added a commit
that referenced
this pull request
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.