Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Starter Kit dropdown menu #278

Merged
merged 4 commits into from
Jul 25, 2019
Merged

[ENH] Starter Kit dropdown menu #278

merged 4 commits into from
Jul 25, 2019

Conversation

franklin-feingold
Copy link
Collaborator

@franklin-feingold franklin-feingold commented Jul 18, 2019 •
edited
Loading

Added direct links to - starter kit GitHub repo, tutorials, forum, and wiki. Here is the rendering from the index.

This can bring more attention to the starter kit by directly linking to these resources.

dorahermes
dorahermes previously approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@dorahermes dorahermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! lgtm

sappelhoff
sappelhoff previously approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@sappelhoff sappelhoff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed earlier, I think this keeps the balance between not cluttering the specification yet providing some handles for quickly going to tutorials.

Edit: Forgot to say thanks. Thank you Franklin :-)

@sappelhoff sappelhoff added this to the 1.2.1 milestone Jul 22, 2019
sappelhoff
sappelhoff reviewed Jul 22, 2019
View reviewed changes
mkdocs.yml Outdated Show resolved Hide resolved
@sappelhoff sappelhoff dismissed their stale review July 23, 2019 09:04

need to finish discussion first: #278 (comment)

@franklin-feingold @sappelhoff
Apply suggestions from code review
d9c7087 
Co-Authored-By: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
@effigies effigies merged commit a58a389 into bids-standard:master Jul 25, 2019
@franklin-feingold franklin-feingold deleted the dropdown_menu branch August 5, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies approved these changes

@sappelhoff sappelhoff sappelhoff approved these changes

@dorahermes dorahermes dorahermes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@franklin-feingold @effigies @dorahermes @sappelhoff