[ENH] Adding Contributors and updating contributions

[franklin-feingold]

No description provided.

[effigies]

Seems fine. @raamana Look good to you?

I don't know Fidel's handle...

[franklin-feingold]

I DM'ed with both Pradeep and Fidel to confirm the contribution credit

[effigies]

I wonder if it makes more sense to make a wiki page where people continue to add themselves, and then we just import that page in the release process.

[PeerHerholz]

Sorry I'm late to the party, but being the selfish person I am, I wanted to add my name to the contributors. Before creating another PR for that: could you (@franklin-feingold) maybe add me as well? Sorry again.

@miykael: you're also not listed yet. Wanna be included?

[effigies]

@PeerHerholz @miykael I'd suggest just adding yourself with the emojis you want using the suggest changes feature, and then @franklin-feingold can sort after committing.

[effigies]

I got some thumbs up... https://github.com/bids-standard/bids-specification/wiki/Contributors

If this seems like a good idea, we should add it to the contribution guide.

[raamana]

Thanks Franklin, appreciate it.

PS: I also admit my selfish- and shamelessness 😀

[effigies]

@franklin-feingold I updated the wiki with all of the current suggestions, if you just want to copy-paste that in.

[franklin-feingold]

Thank you @effigies for putting together the contributor wiki! I noticed for this wiki that if they are not signed in to GitHub (or perhaps an admin on the repo) they are not able to edit. I like the idea of having a dynamic page that can be copied and pasted in before a release.

[sappelhoff]

I noticed for this wiki that if they are not signed in to GitHub (or perhaps an admin on the repo) they are not able to edit. I like the idea of having a dynamic page that can be copied and pasted in before a release.

Then perhaps we should get back to a Google Doc 🤔 similar to the wiki page that Chris M created

[KirstieJane]

The wiki is currently set up to only allow edits from folks with push access. I’d recommend undoing that checkbox (in settings) and then only being logged into GitHub will be required (which I think is good because then we can track who makes changes).

Just while I’m here, I don’t think it should be the responsibility of the contributor to add themselves. It makes me sad that folks here have apologised and called themselves selfish while asking to be added, and I think there are likely a lot of other people who don’t put themselves forward when they HAVE contributed. In the Turing Way community we have a box in the PR template that contributors have to check to say that they’ve added themselves to the list which I think nudges recording the contribution well, but ultimately I think the person reviewing should check that they’re there.

[sappelhoff]

I think we can merge this PR for now, keeping the following three points in mind:

1. We should regularly ask the community to update / add their names to the contributors list ... some/one week/s before each release might be an acceptable time frame
2. We should use the WIKI page for contributors to "add themselves", then to be transferred into a commit via some maintainer (or contributor who wants to do it) --> we should make clear, that a GitHub account is needed for this
3. Whoever merges a pull request by some contributor should double check and assure that contributor is listed in the contributors list

[franklin-feingold]

This PR should be ready (added in Mikael from #292)

+1 with the 3 points to keep in mind. Perhaps editing the PR template could be helpful for ensuring new contributors are properly credited for their time and work. My only concern with the wiki is the necessity for a GitHub account (could be a low barrier but something to consider)

[KirstieJane]

Are the three points @sappelhoff mentioned in the comment above #284 (comment) captured somewhere? Is there any sort of guidance for maintainers/reviewers that exists?

If it doesn't, then I think "keeping things in mind" is a rather fragile solution.

[franklin-feingold]

I agree - I think documenting these points is needed, we have the maintainers doc that will provide most of this guidance. I think 1 and 3 can be in the maintainers guide, 2 could be the PR template. Noting it here to further place into a issue

wdyt?

[KirstieJane]

Yep! Those places sound great! Just wanted to make sure the information didn’t stay in a “soon to be closed” PR 🌟

[sappelhoff]

Cool, thanks Franklin and Kristie.

Thumbs up for merging this one. It's good to see lots of past and current contributors now being appropriately credited!

[franklin-feingold]

cc @effigies for a review - I think this is ready to merge

[sappelhoff]

thanks @franklin-feingold et al.